Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for enhanced RTMP specification #19

Merged
merged 1 commit into from
May 9, 2023
Merged

Conversation

Qizot
Copy link
Member

@Qizot Qizot commented May 8, 2023

This PR adds support for enhanced RTMP specification.

Even though we will not be handling the additional protocols (AV1, HEVC, VP9) we will notify the parent element about the unsupported codec instead (and eventually crashed if the notification doesn't get handled after 300 packets).

The motivation behind this PR is a recently merged PR to OBS that adds support for the mentioned codecs by extending the FLV functionality.

@Qizot Qizot requested a review from daniel-jodlos as a code owner May 8, 2023 09:01
@Qizot Qizot force-pushed the enhanced-rtmp-spec branch from 2f12a0e to f110cda Compare May 8, 2023 09:02
lib/membrane_flv_plugin/parser.ex Outdated Show resolved Hide resolved
@Qizot Qizot force-pushed the enhanced-rtmp-spec branch from f110cda to f121954 Compare May 9, 2023 10:50
@Qizot Qizot merged commit 9d6fbde into master May 9, 2023
@Qizot Qizot deleted the enhanced-rtmp-spec branch May 9, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants