Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix hash vulnerability when generating password recovery #417

Merged

Conversation

WelisonR
Copy link
Contributor

@WelisonR WelisonR commented May 5, 2021

Description

This pull request fix a vulnerability in the generated hash used to recover password. The main problem is that the hash input is known, because it is only based on timestamp and user e-mail, so with some attempts it is possible to change the user password. The code also uses MD5 hash function to generate the hash, that has a lot of vulnerabilities known today.

Resolves (Issues)

Resolve #416

General tasks performed

  • Add a random argument to hash input with secrets library;
  • Change MD5 hash function to SHA256.

Have you confirmed the application builds locally without error? See here.

  • Yes

@vjpixel
Copy link
Member

vjpixel commented May 7, 2021

I'm waiting for it to be live on dev.jandig.app so I can review it from a user perspective.

@pablodiegoss

@pablodiegoss pablodiegoss merged commit 11b9f36 into memeLab:develop Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulnerability problem in password recovery
5 participants