Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Limit input for generator page #419

Merged

Conversation

GabrielDVpereira
Copy link
Contributor

@GabrielDVpereira GabrielDVpereira commented May 6, 2021

Description

The input that takes the user files was accepting all types of file. We limited it to accept only images so the user doesn't submit a file with a wrong format. We also added a cursor pointer to the buttons of the page to improve user experience.

Resolves (Issues)

#418

Issues that have been resolved with this PR.

General tasks performed

  • added accept="image/* to the input that takes the user files
  • added a cursor:pointer css property to all buttons of the page

Have you confirmed the application builds locally without error? See here.

  • Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit files shown to the user when trying to upload an image to Jandig Generator.
3 participants