Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] #480 - Problem running/building django container image #481

Merged

Conversation

durvalcarvalho
Copy link
Collaborator

Description

To solve the Django container build/running problem, the poetry installation routine was updated and the Dockerfile files (base.Dockerfile and Dockerfile) were merged.

Resolves (Issues)

#480 Problem running/building django container image: poetry command not found

General tasks performed

  • Updated the URL where the poetry install script was being downloaded from.
  • Merged the two Dockerfile files

Have you confirmed the application builds locally without error? See here.

  • Yes

Copy link
Member

@pablodiegoss pablodiegoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requirements image and base dockerfile were an old structure that isn't needed anymore, thanks for the merger of both and fixes on poetry installation.

Can you also delete the build_base.sh script in this PR? or else it will become deprecated calling images that don't exist anymore.

@durvalcarvalho
Copy link
Collaborator Author

durvalcarvalho commented Oct 28, 2022

This requirements image and base dockerfile were an old structure that isn't needed anymore, thanks for the merger of both and fixes on poetry installation.

Can you also delete the build_base.sh script in this PR? or else it will become deprecated calling images that don't exist anymore.

You are right! I had forgotten about that!
Done!

Copy link
Member

@pablodiegoss pablodiegoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@pablodiegoss pablodiegoss merged commit 009cd05 into memeLab:develop Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants