Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zefyr view #63

Merged
merged 13 commits into from
Jan 2, 2019
Merged

Zefyr view #63

merged 13 commits into from
Jan 2, 2019

Conversation

pulyaevskiy
Copy link
Contributor

Addresses #26 by introducing a new non-scrollable and read-only ZefyrView widget. It can be embedded in any scrollable like ListView.

@codecov
Copy link

codecov bot commented Jan 1, 2019

Codecov Report

Merging #63 into master will increase coverage by <.01%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   93.04%   93.05%   +<.01%     
==========================================
  Files          11       11              
  Lines        1050     1051       +1     
==========================================
+ Hits          977      978       +1     
  Misses         73       73
Impacted Files Coverage Δ
...ackages/notus/lib/src/heuristics/insert_rules.dart 83.82% <ø> (ø) ⬆️
packages/notus/lib/src/document/line.dart 96.27% <100%> (ø) ⬆️
packages/notus/lib/src/document/block.dart 90% <100%> (ø) ⬆️
packages/notus/lib/src/convert/markdown.dart 99.09% <100%> (ø) ⬆️
packages/notus/lib/src/document/node.dart 96.11% <100%> (ø) ⬆️
packages/notus/lib/src/document.dart 97.93% <100%> (ø) ⬆️
packages/notus/lib/src/document/attributes.dart 86.95% <100%> (ø) ⬆️
...ackages/notus/lib/src/heuristics/delete_rules.dart 100% <100%> (ø) ⬆️
packages/notus/lib/src/document/leaf.dart 94.62% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 858d2f1...11431dd. Read the comment docs.

@pulyaevskiy pulyaevskiy merged commit 8e3e786 into master Jan 2, 2019
@Panthro
Copy link

Panthro commented Jan 7, 2019

I WANT THIS! :-)

Need this feature so bad, my user base is asking for this feature non stop! :-)

Any plans on a new release?

@pulyaevskiy
Copy link
Contributor Author

You can try this out if you switch to git dependency on your pubspec.

Note though i haven’t released it yet because I expect some breaking changes to happen to this soon, meaning I’m not entirely satisfied with some inner workings.

Otherwise it is actually quite stable and usable. If living on the bleeding edge is your thing, definitely check it out and let me know what you think.

@pulyaevskiy pulyaevskiy deleted the zefyr-view branch February 1, 2019 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants