Indicate whether the selected folder is writeable

Issue #275
mendhak · Oct 11, 2014 · 477d76f · 477d76f
1 parent 8c6bc4b
commit 477d76f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/gpslogger/src/main/java/com/mendhak/gpslogger/settings/LoggingSettingsActivity.java b/gpslogger/src/main/java/com/mendhak/gpslogger/settings/LoggingSettingsActivity.java
@@ -27,6 +27,7 @@
 import android.preference.Preference;
 import android.preference.PreferenceActivity;
 import android.preference.PreferenceManager;
+import android.text.Html;
 import android.view.MenuItem;
 import com.mendhak.gpslogger.GpsMainActivity;
 import com.mendhak.gpslogger.R;
@@ -107,7 +108,11 @@ protected void onPostCreate(Bundle savedInstanceState) {
 
         Preference gpsloggerFolder = (Preference) findPreference("gpslogger_folder");
         gpsloggerFolder.setOnPreferenceClickListener(this);
-        gpsloggerFolder.setSummary(prefs.getString("gpslogger_folder", Utilities.GetDefaultStorageFolder(getApplicationContext()).getAbsolutePath()));
+        String gpsLoggerFolderPath = prefs.getString("gpslogger_folder", Utilities.GetDefaultStorageFolder(getApplicationContext()).getAbsolutePath());
+        gpsloggerFolder.setSummary(gpsLoggerFolderPath);
+        if(!(new File(gpsLoggerFolderPath)).canWrite()){
+            gpsloggerFolder.setSummary(Html.fromHtml("<font color='red'>" + gpsLoggerFolderPath + "</font>"));
+        }
 
         CheckBoxPreference chkLog_opengts = (CheckBoxPreference) findPreference("log_opengts");
         chkLog_opengts.setOnPreferenceClickListener(this);
@@ -169,6 +174,11 @@ public synchronized void onActivityResult(final int requestCode, int resultCode,
                 }
                 tracer.debug("Folder path selected" + filePath);
 
+                if(!chosenFile.canWrite()){
+                    Utilities.MsgBox(getString(R.string.sorry), getString(R.string.pref_logging_file_no_permissions), LoggingSettingsActivity.this);
+                    return;
+                }
+
                 SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(getApplicationContext());
                 SharedPreferences.Editor editor = prefs.edit();
                 editor.putString("gpslogger_folder", filePath);
@@ -177,6 +187,8 @@ public synchronized void onActivityResult(final int requestCode, int resultCode,
                 Preference gpsloggerFolder = (Preference) findPreference("gpslogger_folder");
                 gpsloggerFolder.setSummary(filePath);
 
+
+
             } else if (resultCode == Activity.RESULT_CANCELED) {
                 tracer.debug("No file selected");
             }

diff --git a/gpslogger/src/main/res/values/strings.xml b/gpslogger/src/main/res/values/strings.xml
@@ -474,5 +474,6 @@
     <string name="listeners_summary">Which location providers to use when they are available; GPS for satellites, Network for cell tower/wifi, Passive is a special provider that listens for locations requested from other applications.</string>
     <string name="listeners_title">Location providers</string>
     <string name="autosend_frequency_hint">Number of minutes</string>
+    <string name="pref_logging_file_no_permissions">That folder is not writable by GPSLogger</string>
 
 </resources>