-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Java 17 and 21 #713
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sailhenz
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sailhenz
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good
mukund-padale
added a commit
that referenced
this pull request
Feb 15, 2024
* Updated the maintained versions to match the documentation * Update test_deprecations.py updated the versions in the test * Update runtime.py added version 7 again for extended support * Update test_deprecations.py added some test cases * Added support for Java 17 and 21 (#713) * added java support for 17 and 21 * added more logs to debug issue * added exception handling if key is not found * removed extra log line * Added support for java 11 * Updated doc * Fix: argument of type 'NoneType' is not iterable * fix if java version is different than 17 or 21 * added log line * added log line for debugging purpose * added log line for debugging purpose * added log line for debugging purpose - 1 * added log line for debugging purpose * added log line for debug * added log line for debug - 1 * added log line for debug - 1 * added log line for debug - 1 * added log line for debug - 1 * added log line for debug - 1 * pass build path * removed extra logs * java version is an integer not string --------- Co-authored-by: Yornik Heyl <[email protected]> Co-authored-by: Joey den Broeder <[email protected]> Co-authored-by: Yornik Heyl <[email protected]> Co-authored-by: mukund-padale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.