Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Java 17 and 21 #713

Merged
merged 23 commits into from
Feb 12, 2024

Conversation

mukund-padale
Copy link
Collaborator

No description provided.

Copy link
Contributor

@sailhenz sailhenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sailhenz sailhenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good

@mukund-padale mukund-padale merged commit 0fde4a8 into develop Feb 12, 2024
27 checks passed
mukund-padale added a commit that referenced this pull request Feb 15, 2024
* Updated the maintained versions to match the documentation

* Update test_deprecations.py

updated the versions in the test

* Update runtime.py

added version 7 again for extended support

* Update test_deprecations.py

added some test cases

* Added support for Java 17 and 21 (#713)

* added java support for 17 and 21

* added more logs to debug issue

* added exception handling if key is not found

* removed extra log line

* Added support for java 11

* Updated doc

* Fix: argument of type 'NoneType' is not iterable

* fix if java version  is different than 17 or 21

* added log line

* added log line for debugging purpose

* added log line for debugging purpose

* added log line for debugging purpose - 1

* added log line for debugging purpose

* added log line for debug

* added log line for debug - 1

* added log line for debug - 1

* added log line for debug - 1

* added log line for debug - 1

* added log line for debug - 1

* pass build path

* removed extra logs

* java version is an integer not string

---------

Co-authored-by: Yornik Heyl <[email protected]>
Co-authored-by: Joey den Broeder <[email protected]>
Co-authored-by: Yornik Heyl <[email protected]>
Co-authored-by: mukund-padale <[email protected]>
@jeohist jeohist deleted the DEP-5467_add_support_java_17_21 branch April 17, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants