Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option --config to parse JSON configs #16

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Conversation

dbelokon
Copy link
Contributor

@dbelokon dbelokon commented Oct 9, 2021

Fixes #15.

@menghif
Copy link
Owner

menghif commented Oct 11, 2021

Hi Diana, thank you for the PR, it looks good :)

2 small things missing:

  • Make sure the 'file.json' exists. You can use fs.existsSync(argv.config)
  • Make sure that only a json file can be used as input (A folder named 'folder.json' returns an error). You can use fs.statSync(argv.config).isFile()

Thank you!

@dbelokon
Copy link
Contributor Author

Hey @menghif! I have made the changes you wanted. Let me know if you need anything else 😀

@menghif menghif merged commit 77d8b09 into menghif:main Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Feature: Support --config with Config file
2 participants