-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make ci ✅ with 💚 and 🥑s #371
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
feat: make ci ✅ with 💚 and 🥑s
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is greeeeeeeen 🤩🤩🤩
lgtm, just some questions/suggestions
Co-authored-by: chapati <[email protected]>
Co-authored-by: chapati <[email protected]>
@philipraetsch thanks for the suggestions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we can disable timestamp
matcher at the config level. Because,
1- I don't think we rely on it at a critical level
2- Not sure about specifics of Celo, but it is much harder to exploit in a PoS setup
3- Timestamps are used frequently in our repo
The rest looks good as it is.
Description
Other changes
SortedOracles.sol
tocommon
because moving forward that contract will be owned byclabs
and we will need to deploy it through their pipeline. So everything incommon
will move to@celo/contracts
, including SortedOracles.Tested
In progress
Related issues
N/A
Backwards compatibility
N/A
Documentation
N/A