Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce CI foundry test verbosity #475

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

m-chrzan
Copy link
Collaborator

@m-chrzan m-chrzan commented Jul 4, 2024

Description

The verbosity setting for CI tests was set to 4, which outputs full stack traces for all (even passed) tests. This leads to extremely verbose output that doesn't get fully displayed in GitHub UI (need to download a 52MB, 350k line log file). This makes it more time consuming to pinpoint what specific tests are causing the workflow to fail. Example.

I propose we set verbosity to 3, which should still output stack traces for failing tests. The one thing missing will be setup traces for failing tests, but this should still be a quality of life improvement.

Other changes

Nothing, this is a one byte change.

Tested

Will need to look at CI output for this PR.

Copy link
Contributor

@chapati23 chapati23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please

@m-chrzan m-chrzan changed the title Reduce CI foundry test verbosity chore: reduce CI foundry test verbosity Jul 4, 2024
@m-chrzan m-chrzan merged commit 7323a61 into develop Jul 4, 2024
3 of 5 checks passed
@m-chrzan m-chrzan deleted the chore/reduce-ci-verbosity branch July 4, 2024 11:42
bowd pushed a commit that referenced this pull request Aug 26, 2024
### Description

The verbosity setting for CI tests was set to `4`, which outputs full
stack traces for all (even passed) tests. This leads to extremely
verbose output that doesn't get fully displayed in GitHub UI (need to
download a 52MB, 350k line log file). This makes it more time consuming
to pinpoint what specific tests are causing the workflow to fail.
[Example](https://github.com/mento-protocol/mento-core/actions/runs/9779856065/job/27000074200?pr=456).

I propose we set verbosity to `3`, which should still output stack
traces for failing tests. The one thing missing will be setup traces for
failing tests, but this should still be a quality of life improvement.

### Other changes

Nothing, this is a one byte change.

### Tested

Will need to look at CI output for this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants