Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Disable Initializer #576

Merged
merged 4 commits into from
Feb 7, 2025
Merged

Feat: Disable Initializer #576

merged 4 commits into from
Feb 7, 2025

Conversation

RyRy79261
Copy link
Contributor

Description

This PR addresses the implementation having an exposed and callable, however without any structural risk, initializer in future implementations of the Locking contract

test/unit/governance/GovernanceFactory.t.sol Outdated Show resolved Hide resolved
test/integration/governance/GovernanceIntegration.t.sol Outdated Show resolved Hide resolved
test/fork/upgrades/LockingUpgradeForkTest.sol Outdated Show resolved Hide resolved
contracts/governance/deployers/LockingDeployerLib.sol Outdated Show resolved Hide resolved
@RyRy79261 RyRy79261 requested a review from baroooo February 7, 2025 11:43
@RyRy79261 RyRy79261 requested a review from nvtaveras February 7, 2025 11:51
@RyRy79261 RyRy79261 merged commit af4b7d6 into develop Feb 7, 2025
5 checks passed
@RyRy79261 RyRy79261 deleted the fix/initializer branch February 7, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants