Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removes content-type check for json #181

Merged
merged 7 commits into from
Mar 3, 2022
Merged

removes content-type check for json #181

merged 7 commits into from
Mar 3, 2022

Conversation

coreGreenberet
Copy link
Contributor

workaround for #177

@coreGreenberet coreGreenberet mentioned this pull request Feb 9, 2022
Closed
@TKIPisalegacycipher
Copy link
Collaborator

Let's hold on this until dust settles on server-side fixes.

@TKIPisalegacycipher
Copy link
Collaborator

We can expect application/json content types for endpoints that return JSON content; this excepts any endpoint responding with a 204 No Content.

Given this, would you want to modify your PR in any way?

@coreGreenberet
Copy link
Contributor Author

I think we should keep the PR like it is for 3 reasons:

  1. The behaviour is then same as the request based version
  2. There is no need for additional checks like 204 as the .json() method will handle that
  3. If the backend creates a similiar issue again, we won't have troubles in the library

@TKIPisalegacycipher TKIPisalegacycipher merged commit ce20540 into meraki:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coreGreenberet @TKIPisalegacycipher