Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed References to package.path - pyinstaller support Issue #187 #188

Merged
merged 2 commits into from
Jun 2, 2022

Conversation

CamoDunn
Copy link
Contributor

@CamoDunn CamoDunn commented Apr 7, 2022

…r support

Changes: 1. Updated Meraki and Meraki_v0 to look back at package for reference instead of backing through folder structure.
This will provide support for pyinstaller.

Updated Example "apiData2CSV_v1.py" It was still looking for package meraki_v1 which has been renamed to meraki.

Ref Issue #187

…r support

Changes: 1. Updated Meraki and Meraki_v0 to look back at package for reference instead of backing through folder structure.
This will provide support for pyinstaller.

Updated Example "apiData2CSV_v1.py" It was still looking for package meraki_v1 which has been renamed to meraki.
@CamoDunn
Copy link
Contributor Author

CamoDunn commented Apr 7, 2022

Also includes reference to broken example file containing reference to meraki_v1

@CamoDunn CamoDunn changed the title Changed References from folder structure to package.path - pyinstalle… Changed References to package.path - pyinstaller support Issue #187 Apr 7, 2022
Copy link
Collaborator

@TKIPisalegacycipher TKIPisalegacycipher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. I added some notes -- looks like minor changes might be required.

meraki_v0/aio/__init__.py Show resolved Hide resolved
meraki_v0/aio/__init__.py Outdated Show resolved Hide resolved
@CamoDunn
Copy link
Contributor Author

CamoDunn commented Apr 8, 2022

@TKIPisalegacycipher this is my first collab, let me know if there is something I'm doing wrong as far as pushing or confirming changes were made.

Copy link
Collaborator

@TKIPisalegacycipher TKIPisalegacycipher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating this.

@TKIPisalegacycipher TKIPisalegacycipher merged commit c69ec31 into meraki:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants