Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: Fixed missing suppressprint. #42

Merged
merged 1 commit into from
May 25, 2019
Merged

bugfix: Fixed missing suppressprint. #42

merged 1 commit into from
May 25, 2019

Conversation

danmanners
Copy link
Contributor

Fixed an issue with a missing if suppressprint is False: line, printing out text even when suppressed.

@danmanners
Update meraki.py

Verified

This commit was signed with the committer’s verified signature.
jrjohnson Jon Johnson
GPG key ID: 673E14A72062F1D0
Verified
Learn about vigilant mode
ad2368a
pocc
pocc approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@pocc pocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

pocc
pocc suggested changes May 24, 2019
View reviewed changes
Copy link
Contributor

@pocc pocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash your commits? This is essentially rebasing to the commit prior to your first and then force pushing to your repo (and the PR).

@danmanners
Copy link
Contributor Author

Squashed! My apologies for missing that.

@pocc pocc merged commit 1ed80e7 into meraki:master May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pocc pocc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danmanners @pocc