-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plan and subscription resources #60
Conversation
Hello, @gustav0! Thank you for your contribution! About your questions:
|
Hey @lucmantovani, thanks for your response! Alright, I was just checking about the delete because you guys have deletion methods in this sdk that the API doesn't show. About question number 2, I used the very same API ACCESS TOKEN you guys used in all your unit tests: The test was about changing the |
@gustav0 thanks for contributing our Python SDK, I left some comments about Lint, link to the docs and a tweak to the path that updates the subscription. Any doubt, I am available. Saludos |
@eltinMeli all set, linting is good and tests are 100% working. |
@eltinMeli done. |
Hey, before asking for an actual merge, I would like to know about 2 things:
The template with id {plan_id} does not exist
Do you have any idea why is this happening? I made sure the plan actually exists.
Besides that, I believed I could implement a lot more tests, but I don't think they will be useful as our goal is to verify the API calls are being made correctly.
Anything you guys think needs some change, just let me know, and I will get to it.