Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Support APNs payload extensions for Title & Subtitle #70

Merged
merged 5 commits into from
Jul 13, 2017

Conversation

timakin
Copy link
Contributor

@timakin timakin commented Jul 3, 2017

This PR allows to send Title and Subtitle with an existing payload.

From iOS ver10, it supports Bold-styled title and subtitles to display rich notifications.

@cubicdaiya
Copy link
Contributor

Add description to SPEC.md below.

https://github.com/mercari/gaurun/blob/master/SPEC.md#post-push

@timakin
Copy link
Contributor Author

timakin commented Jul 3, 2017

@cubicdaiya Thanks for ur quick check.
Added a description to SPEC about these params.

SPEC.md Outdated
|message |string |message for notification |o | | |
|subtitle |string |subtitle for notification |o | |only iOS |
Copy link
Contributor

@cubicdaiya cubicdaiya Jul 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this optional? ( title, too) if it is optional (not required), the value is not o but - in required row.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, title and subtitle are optional values.
If they weren't set, only message will be displayed.

As below, these values are optional.
https://github.com/RobotsAndPencils/buford/blob/1589c179b764ddceb204a439d9bf366f04c55f9b/payload/aps.go#L37

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is optional, update the value with - in required row.

@timakin
Copy link
Contributor Author

timakin commented Jul 4, 2017

@cubicdaiya
Fixed the spec documentation.
And the position of them was wrong so changed the order.

@timakin
Copy link
Contributor Author

timakin commented Jul 5, 2017

@cubicdaiya
Sorry to bother you again.
could you check the last fix?
My team is looking forward this opt 🙇

@cubicdaiya
Copy link
Contributor

@timakin Sorry. As we are busy for another project, one moment, please.

@cubicdaiya cubicdaiya merged commit e972312 into mercari:master Jul 13, 2017
@cubicdaiya
Copy link
Contributor

@timakin Merged. Thanks.

@timakin timakin deleted the feature/apns-payload-extension branch July 14, 2017 01:14
cubicdaiya added a commit that referenced this pull request Sep 29, 2017
Changes

* Support APNs payload extensions for `Title & Subtitle` refs #70 Thanks @timakin
* Add UNNotificationCategory option for iOS. refs #73 Thanks @timakin
* Support writing pid file refs #76
* bugfix: set Content-Type: application/json; charset=utf-8 for json response. refs #80
* stat: appened charset to Content-Type. refs #81
* api: abolished GET /config/app. refs #82
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants