Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gradle 7.4, make gradle 8.0 compatible + update spring boot 2.64 + dependency updates #1080

Merged
merged 12 commits into from
Mar 9, 2022

Conversation

@de-jcup de-jcup requested a review from Jeeppler February 28, 2022 08:47
Copy link
Member

@Jeeppler Jeeppler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not enough to just upgrade the SpringBoot version. SpringBoot 2.6.4 upgraded a number of packages: https://github.com/spring-projects/spring-boot/releases/tag/v2.6.4. Some of the packages like slf4j are explicitly mentioned in libraries.gradle. The problem is, we have to upgrade the dependencies in libraries.gradle manually, otherwise we include the same dependencies multiple times.

Upgrading the dependencies manually is tedious.

@de-jcup de-jcup changed the title Upgraded spring boot dependency to 2.6.4 #1057 Make gradle 8.0 compataible + update spring boot 2.64 + dependency updates Mar 1, 2022
@de-jcup de-jcup changed the title Make gradle 8.0 compataible + update spring boot 2.64 + dependency updates Use gradle 7.4, make gradle 8.0 compatible + update spring boot 2.64 + dependency updates Mar 1, 2022
de-jcup and others added 4 commits March 1, 2022 08:28
- updated `spring_boot_dependagen.gradle`
- replaced `libraries` parts where
  possible with `spring_boot_dependency`
- removed hsql db dependency (never used)
- special automatic handled dependencies like h2, flyway etc.
  have now no longer a version number inside - so relying
  full on spring boot dependency management
- removed apache_commons_lang3 #1119
- removed unnecessary settings
- all versions of additional libraries are defined inside
  variables of array `libraryVersion` now
@de-jcup de-jcup requested a review from Jeeppler March 7, 2022 16:47
@de-jcup de-jcup marked this pull request as draft March 7, 2022 16:48
@de-jcup de-jcup marked this pull request as ready for review March 8, 2022 07:38
Copy link
Member

@Jeeppler Jeeppler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. However, I found one odd dependency: spring boot starter mongodb. Why do we need that?

@de-jcup de-jcup merged commit bcd5f74 into develop Mar 9, 2022
@de-jcup de-jcup deleted the feature-1057-upgrade-spring-boot-2.6.4 branch March 9, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants