-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gradle 7.4, make gradle 8.0 compatible + update spring boot 2.64 + dependency updates #1080
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not enough to just upgrade the SpringBoot version. SpringBoot 2.6.4 upgraded a number of packages: https://github.com/spring-projects/spring-boot/releases/tag/v2.6.4. Some of the packages like slf4j
are explicitly mentioned in libraries.gradle
. The problem is, we have to upgrade the dependencies in libraries.gradle
manually, otherwise we include the same dependencies multiple times.
Upgrading the dependencies manually is tedious.
- updated `spring_boot_dependagen.gradle` - replaced `libraries` parts where possible with `spring_boot_dependency` - removed hsql db dependency (never used) - special automatic handled dependencies like h2, flyway etc. have now no longer a version number inside - so relying full on spring boot dependency management - removed apache_commons_lang3 #1119 - removed unnecessary settings - all versions of additional libraries are defined inside variables of array `libraryVersion` now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. However, I found one odd dependency: spring boot starter mongodb. Why do we need that?
This PR
Pair
withMap
+ remove apache.commons.lang3 dependency #1119