Fix readDataAndKeys #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SQLiteStorageEngineTest succeeds, because its implementation of `readDataAndKeys` does not rely on the fault logic inherited from the default implementation on `StorageEngine` The DiskStorageEngineTest fails. Only five keys exist in the database (`0`, `1`, `2`, `3`, and `4`). However, 10 get requested in reverse order. The faulty logic means that key `9` gets the data associated with key `4`, key `8` with key `3`, and so on down to key `5` getting the data meant for key `0`. This means that comparing the returned _keys_ fails, but the comparing the returned _data_ succeeds. The ObjectStorageTest fails, for similar reasons. It is also using `zip()` to construct the returned array, blindly assuming that the object retrieved for each key exists.
Fixes mergesort#24 Using `zip()` loses the association between keys and values, because the array returned from `read(keys:)` does not provide information about _skipped_ keys (See mergesort#26).
|
This is a great catch, thank you so much @dannynorth! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug exists in
readDataAndKeys(#24) where requesting non-existent keys will cause subsequent keys to be associated with the wrong data.This fixes that.