Extend the br tag regex
#1156
Merged
Extend the br tag regex
#1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends the `br` tag regex to accommodate an arbitrary amount of any type of whitespace instead of a single space character, which holds more closely to the HTML spec[1] This extends the fix to mermaid-js#702 added in mermaid-js#1153 [1]: http://www.w3.org/TR/REC-xml/#sec-starttags
|
Hey @gene1wood! Thank you very much for your contribution. |
This adds tests for the case where * multiple pieces of whitespace are used * one of those whitespace characters is a tab
|
@dunning-kruger I added what I think are tests, I followed GDFaber's example and I don't actually know what I'm doing so hopefully this is right. Could you glance at b4f9dd4 and see if it looks right? |
IOrlandoni
approved these changes
Dec 23, 2019
klemmchr
added
Graph: Sequence
Type: Bug / Error
knsv
approved these changes
Dec 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This extends the
brtag regex to accommodate an arbitrary amount ofany type of whitespace instead of a single space character, which holds
more closely to the HTML spec1
This extends the fix to #702 added in #1153
Design Descisions
This replaces the use of
?\/>with\s*\/>which changes two things