feat: add sanitization consistently #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindseywild
reviewed
Apr 7, 2022
src/diagrams/er/erDb.js
Outdated
| @@ -69,15 +72,17 @@ const getRelationships = () => relationships; | |||
|
|
|||
| // Keep this - TODO: revisit...allow the diagram to have a title | |||
| const setTitle = function (txt) { | |||
| title = txt; | |||
| let sanitizedText = sanitizeText(txt, configApi.getConfig()); | |||
There was a problem hiding this comment.
Do we need to pass in configApi.getConfig() here since it's already passed into the sanitizeText function on line 11?
There was a problem hiding this comment.
You are right. That is not necessary. We can remove that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Ensure any where we are adding accessibility already that it is sanitized.
📏 Design Decisions
Used the common sanitizer.
📋 Tasks
Make sure you
developbranch