Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'ms' duration to gantt diagram #3355

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

vallsv
Copy link
Contributor

@vallsv vallsv commented Aug 24, 2022

📑 Summary

Hi. This PR features task duration in milliseconds.

Resolves #3028

image

    gantt
      title A Gantt Diagram
      dateFormat x
      axisFormat %L
      section Section
      A task           :a1, 0, 30ms
      Another task     :after a1, 20ms
      section Another
      Another another task      :b1, 20, 12ms
      Another another another task     :after b1, 24ms

📏 Design Decisions

No crazy things

  • Fix the regex to match multi character including ms
    • Previously the string was not matched until the end -> 10ms was matched as 10 minutes
    • The side effect is now a duration like 10mhj will probably not be matched anymore -> which is IMO better
  • Use ms to properly convert the duration in millisecond

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@vallsv vallsv changed the title Added 'ms' duration Added 'ms' duration to gantt diagram Aug 24, 2022
Copy link
Member

@Yash-Singh1 Yash-Singh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gantt Chart - possibility to use milliseconds or decimal values for seconds
2 participants