Add new chart xychart

[subhash-halder]

📑 Summary

This PR will contain the implementation of the XY chart

Resolves #4269

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

• 📖 have read the contribution guidelines
• 💻 have added unit/e2e tests (if appropriate)
• 📓 have added documentation (if appropriate)
• 🔖 targeted develop branch

[codecov]

Codecov Report

Merging #4413 (936319b) into develop (157c90e) will increase coverage by 5.82%.
The diff coverage is 83.19%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4413      +/-   ##
===========================================
+ Coverage    74.11%   79.94%   +5.82%     
===========================================
  Files          143      164      +21     
  Lines        12697    13623     +926     
  Branches       601      693      +92     
===========================================
+ Hits          9411    10891    +1480     
+ Misses        3132     2583     -549     
+ Partials       154      149       -5     

Flag	Coverage Δ
e2e	85.23% <93.18%> (+7.21%)	⬆️
unit	43.29% <23.59%> (-0.38%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
packages/mermaid/src/defaultConfig.ts	47.98% <100.00%> (+0.77%)	⬆️
...s/mermaid/src/diagram-api/diagram-orchestration.ts	83.33% <ø> (ø)
...aid/src/diagrams/quadrant-chart/quadrantBuilder.ts	80.53% <ø> (ø)
...rams/xychart/chartBuilder/components/axis/index.ts	100.00% <100.00%> (ø)
...xychart/chartBuilder/components/axis/linearAxis.ts	100.00% <100.00%> (ø)
...ms/xychart/chartBuilder/components/plot/barPlot.ts	100.00% <100.00%> (ø)
...mermaid/src/diagrams/xychart/chartBuilder/index.ts	100.00% <100.00%> (ø)
...id/src/diagrams/xychart/chartBuilder/interfaces.ts	100.00% <100.00%> (ø)
.../src/diagrams/xychart/chartBuilder/orchestrator.ts	100.00% <100.00%> (ø)
...es/mermaid/src/diagrams/xychart/xychartDetector.ts	100.00% <100.00%> (ø)
... and 15 more

... and 33 files with indirect coverage changes

[subhash-halder]

@sidharthv96 The PR is working only thing left is to add the style part and test cases, for now, the cosmetics are static.

[sidharthv96]

Due to the size of the PR, it might take some time for proper review from everyone. :)

[subhash-halder]

@sidharthv96 No problem, I don't think there will be any huge structural changes.

[nirname]

I think we are finalizing it. There are some minor changes that should be done for the sake of code and documentation quality. Other than that all is fine.

Kudos to @subhash-halder for implementing this enormous and formidable task single-handedly.

[subhash-halder]

@nirname @sidharthv96 I must appreciate your reviewing skills and patience. Thanks again for the detailed review.

[nirname]

There are some lines of code that are not covered by test. And a couple of questions about documentation, that could be clarified. Apart from this, everything is OK.

[nirname]

@knsv there is one more diagram to the project, if you are willing to you can review this. There is a couple of approves already, so you can merge it as it is

[nirname]

@subhash-halder I re-run e2e tests because they failed but seemed to be working previously... and documentation update should've not influenced them. Meantime, try fixing whatever code coverage recommends.

[subhash-halder]

@nirname I am not able to see any error, everything seems to be passed.

[nirname]

@subhash-halder Please, update your PR one more time, there are conflicts in pnpm-lock.yaml. Let's wait a little bit more for everyone willing to make a proper review of this feature. In case no one add valuable comments in the nearest future we will merge it. There is an ongoing refactoring and standardizing of mermaid, but verification of compliance with what we are targeting will be the following step, I think. There is no point in slowing you down.

[Yokozuna59]

I haven't fully reviewed the PR because I'm not really sure how strict I should be about types and structure.
I don't want to be that strict, which would stop the merge of this PR. It has been open for a while, and it has two approvals already.

[mermaid-bot]

@subhash-halder, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.