convert cypress/helpers/util.js to ts

[Yokozuna59]

📑 Summary

• add types for parameter and returned value and variables
• change the deprecated unescape into decodeURIComponent
• change the deprecated btoa into Buffer.from
• create CypressConfig and CypressMermaidConfig and CodeObject types
• add default value for some parameter
• fix wrong config paramater in some cypress spec
  • flowchart
  • mindmap
• allow import ts in ts files

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

• 📖 have read the contribution guidelines
• 💻 have added unit/e2e tests (if appropriate)
• 📓 have added documentation (if appropriate)
• 🔖 targeted develop branch

[Yokozuna59]

@sidharthv96 I have commit a separate commit just converting file into ts 6cbd24f as you suggested. Now it would be easier to to notice the difference. a2cf41c

[Yokozuna59]

It appears the the cypress/tsconfig.json has different config from packages/mermaid/tsconfig.json, so .js imports aren't working, should I update imports to .ts or updating cypress/tsconfig.json is enough?

[sidharthv96]

Why we need 2 commits :)

#4350 (comment)
#4350 (review)

[sidharthv96]

It appears the the cypress/tsconfig.json has different config from packages/mermaid/tsconfig.json, so .js imports aren't working, should I update imports to .ts or updating cypress/tsconfig.json is enough?

I'm fine with either of those, as long as it doesn't break existing functionality.

[Yokozuna59]

Why we need 2 commits :)

#4350 (comment) #4350 (review)

I'm aware of that :), it was a typo, I wrote not instead of now.

---

I'm fine with either of those, as long as it doesn't break existing functionality.

I think changing imports in the whole cypress folder would make the PR larger with no value, so I'll go with updating cypress/tsconfig.json.

[sidharthv96]

Related: #4340

[Yokozuna59]

Related: #4340

I saw it, but the main idea of this PR is just converting, so let's not refactor it. I'll create new PR that add JSDoc with some refactoring, then another one for the stuff discussed here #4552 (comment)

[codecov]

Codecov Report

Merging #4552 (8cd8714) into develop (e66135b) will decrease coverage by 31.69%.
The diff coverage is n/a.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #4552       +/-   ##
============================================
- Coverage    77.01%   45.32%   -31.69%     
============================================
  Files          143       52       -91     
  Lines        14476     6645     -7831     
  Branches       516       18      -498     
============================================
- Hits         11149     3012     -8137     
- Misses        3222     3633      +411     
+ Partials       105        0      -105     

Flag	Coverage Δ
e2e	?
unit	45.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 137 files with indirect coverage changes