Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/5133 sequence diagram fix arrow corner #5309

Conversation

Ronid1
Copy link
Contributor

@Ronid1 Ronid1 commented Feb 22, 2024

📑 Summary

Updated arrowhead coordinates to ensure smooth corner

Partially resolves #5133

📏 Design Decisions

n/a

📋 Tasks

Make sure you

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Feb 22, 2024
Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit d945030
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/65de38d34d31aa0008695292
😎 Deploy Preview https://deploy-preview-5309--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Ronid1 Ronid1 changed the title bug/5133-sequence_diagram_fix_arrow_corner bug/5133 sequence diagram fix arrow corner Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.20%. Comparing base (31a287b) to head (d945030).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5309   +/-   ##
========================================
  Coverage    43.20%   43.20%           
========================================
  Files           23       23           
  Lines         5115     5115           
  Branches        23       23           
========================================
  Hits          2210     2210           
  Misses        2904     2904           
  Partials         1        1           
Flag Coverage Δ
unit 43.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

…bug/5133-sequence_diagram_fix_arrow_corner
@sidharthv96 sidharthv96 merged commit 7689e03 into mermaid-js:develop Mar 23, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrows in sequence diagrams are drawn slightly out of position
2 participants