Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(3801): Multiple Tags support for Git Graph #5647

Merged
merged 10 commits into from
Jul 18, 2024
Merged

feat(3801): Multiple Tags support for Git Graph #5647

merged 10 commits into from
Jul 18, 2024

Conversation

Yash-Singh1
Copy link
Member

@Yash-Singh1 Yash-Singh1 commented Jul 16, 2024

📑 Summary

Adds support for multiple git tags in commits, cherry picks and merges. By the way, could someone give me access to the team's channels on new discord, my username is techblooded.

Resolves #3801

📏 Design Decisions

Modify the grammar to support multiple tags, and modified db and renderer to handle array of tags instead of single tag on a commit.

📋 Tasks

Make sure you

Examples

Left-to-right: (live link)

Git-Graph-diagram-75-should-render-a-gitGraph-with-multiple-tags-on-a-merge-commit snap

Bottom-up: (live link):

Git-Graph-diagram-Git-Graph-Bottom-to-Top-Orientation-Tests-75-should-render-a-gitGraph-with-multiple-tags-on-a-merge-commit-on-bottom-to-top-orientation snap

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Jul 16, 2024
Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit eb714eb
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66989bfcaf33030008d973b8
😎 Deploy Preview https://deploy-preview-5647--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

argos-ci bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 2 added Jul 18, 2024, 4:47 AM

@Yash-Singh1 Yash-Singh1 marked this pull request as ready for review July 16, 2024 20:11
@Yash-Singh1 Yash-Singh1 changed the title Multiple Tags support for Git Graph feat(3801): Multiple Tags support for Git Graph Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 108 lines in your changes missing coverage. Please review.

Project coverage is 5.85%. Comparing base (b1b480a) to head (eb714eb).
Report is 11 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5647      +/-   ##
==========================================
- Coverage     5.86%   5.85%   -0.01%     
==========================================
  Files          274     274              
  Lines        41087   41112      +25     
  Branches       488     488              
==========================================
  Hits          2408    2408              
- Misses       38679   38704      +25     
Flag Coverage Δ
unit 5.85% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/mermaid/src/diagrams/git/gitGraphAst.js 0.00% <0.00%> (ø)
...kages/mermaid/src/diagrams/git/gitGraphRenderer.js 0.00% <0.00%> (ø)

@Yash-Singh1 Yash-Singh1 requested a review from a team July 17, 2024 00:18
@sidharthv96
Copy link
Member

By the way, could someone give me access to the team's channels on new discord, my username is techblooded.

I've asked @huynhicode to add you.

@sidharthv96 sidharthv96 added this pull request to the merge queue Jul 18, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 18, 2024
feat(3801): Multiple Tags support for Git Graph
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 18, 2024
@sidharthv96 sidharthv96 merged commit 61f55fe into develop Jul 18, 2024
28 checks passed
@sidharthv96 sidharthv96 deleted the fix/3801 branch July 18, 2024 16:20
@chardskarth
Copy link

Awesome! @sidharthv96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitGraph support for multiple tags
3 participants