-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Use Streaming Lists when available #255
[Enhancement] Use Streaming Lists when available #255
Conversation
Signed-off-by: Daniel Kiptoon <[email protected]>
Signed-off-by: Daniel Kiptoon <[email protected]>
WatchList feature is enabled Signed-off-by: Daniel Kiptoon <[email protected]>
purposes of the cache store Signed-off-by: Daniel Kiptoon <[email protected]>
Signed-off-by: Daniel Kiptoon <[email protected]>
Signed-off-by: Daniel Kiptoon <[email protected]>
… feature/kiptoonkipkurui/221
Point to note, So this PR is against a branch of meshery where the original PR was made and Reverted to |
Signed-off-by: Daniel Kiptoon <[email protected]>
Signed-off-by: Daniel Kiptoon <[email protected]>
Signed-off-by: Daniel Kiptoon <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #255 +/- ##
========================================
Coverage ? 2.76%
========================================
Files ? 6
Lines ? 398
Branches ? 0
========================================
Hits ? 11
Misses ? 386
Partials ? 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue. |
@KiptoonKipkurui did you toss in the towel here? |
@leecalcote no I hadn't, by my last commit I had resolved the pending issues by then and comments, it was just a matter merging if all was well from the maintainers side |
Description
This PR Addresses an issue of potential runaway usage of memory due to chucking of reported statuses while watching for Kubernetes resources. Kubernetes 1.27 introduces a WatchList feature still at the alpha stage that allows one to get statuses of objects being watched as a streaming list as opposed to current implementations that uses a list request first before a watch request. This is done by setting sendInitialEvents=true param in a watch request.
This PR fixes #221
Notes for Reviewers
Signed commits