Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Use Streaming Lists when available #255

Conversation

KiptoonKipkurui
Copy link
Member

Description
This PR Addresses an issue of potential runaway usage of memory due to chucking of reported statuses while watching for Kubernetes resources. Kubernetes 1.27 introduces a WatchList feature still at the alpha stage that allows one to get statuses of objects being watched as a streaming list as opposed to current implementations that uses a list request first before a watch request. This is done by setting sendInitialEvents=true param in a watch request.
This PR fixes #221

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@KiptoonKipkurui
Copy link
Member Author

Point to note, So this PR is against a branch of meshery where the original PR was made and Reverted to

@KiptoonKipkurui KiptoonKipkurui changed the base branch from revert-247-revert-244-feature/kiptoonkipkurui/221 to master November 2, 2023 13:25
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@1e21ae5). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff            @@
##             master    #255   +/-   ##
========================================
  Coverage          ?   2.76%           
========================================
  Files             ?       6           
  Lines             ?     398           
  Branches          ?       0           
========================================
  Hits              ?      11           
  Misses            ?     386           
  Partials          ?       1           
Flag Coverage Δ
unittests 2.76% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

stale bot commented Jan 26, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Jan 26, 2024
Copy link

stale bot commented Feb 7, 2024

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Feb 7, 2024
@leecalcote
Copy link
Member

@KiptoonKipkurui did you toss in the towel here?

@KiptoonKipkurui
Copy link
Member Author

@leecalcote no I hadn't, by my last commit I had resolved the pending issues by then and comments, it was just a matter merging if all was well from the maintainers side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/stale Issue has not had any activity for an extended period of time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Use Streaming Lists when available
3 participants