Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for UEFI target #14040

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RossComputerGuy
Copy link
Contributor

Requires some new LLVM PR's to be merged - llvm/llvm-project#120632

This PR introduces basic support for UEFI as an OS. The idea is to be able to support projects using Meson to be cross compiled to UEFI using LLVM and using LLVM libc. I likely haven't implemented everything needed but with grepping the source tree, this looks like a good start.

@eli-schwartz
Copy link
Member

This looks interesting, but we should probably install a CI job that tests this.

@RossComputerGuy
Copy link
Contributor Author

Yeah, I only added a new define test to test cases/common/132 get define/meson.build. What other tests should we add in?

@eli-schwartz
Copy link
Member

Try to compile a UEFI executable? See .github/workflows/nonnative.yml for example.

@RossComputerGuy
Copy link
Contributor Author

RossComputerGuy commented Dec 23, 2024

I added a new job to CI, we'll see if LLVM 19 works but very likely will require 20. Support for UEFI targets is kinda new.

@thesamesam
Copy link
Collaborator

I think it's premature to add this if the PR isn't even merged yet, let alone in an LLVM release.

@eli-schwartz
Copy link
Member

The outlook on this approach is anyways pretty grim if the action for installing LLVM simply errors out immediately due to "Error: Unsupported version for platform (os=linux, arch=x64, version=19.1)!"

Why it is necessary to install llvm at action setup time is another matter entirely, which has an unrelated but fascinating history... :)

@RossComputerGuy
Copy link
Contributor Author

Why it is necessary to install llvm at action setup time is another matter entirely

Does Ubuntu not have LLVM 19? I thought it didn't so installing it would make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants