add Ghasedak Sms Provider #101
Conversation
provider/ghasedak/ghasedak.go
Outdated
| // Retrieving required data from 'ghasedak' sections of config.yaml | ||
| type Config struct { | ||
| APIToken string `yaml:"api_token"` | ||
| PhoneNumbers []string `yaml:"phone_numbers"` |
There was a problem hiding this comment.
PhoneNumbers is not used!
There was a problem hiding this comment.
they normally come from the message obj
There was a problem hiding this comment.
'PhoneNumbers' is sender phone number
I will delete this config because not usable in Ghasedak API
There was a problem hiding this comment.
We call this "originator" and it's also on the Message https://github.com/messagebird/sachet/blob/master/sachet.go#L9
There was a problem hiding this comment.
in last pull request, I delete config
There was a problem hiding this comment.
in Kavenegar Provider : Config PhoneNumbers Exist
https://github.com/messagebird/sachet/blob/master/provider/kavenegar/kavenegar.go
|
I added another comment for something small. Else looks good. Did you test it? |
Hi
I add ghasedak sms provider
main address is : https://ghasedak.me/