Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TextMagic as a provider #110

Merged
merged 6 commits into from
Feb 21, 2022
Merged

Conversation

andrewdbate
Copy link
Contributor

As promised in #109, here is a PR which adds support for TextMagic as a provider.

@andrewdbate
Copy link
Contributor Author

Hey @marcelcorso, do you have any feedback on this PR please?

@marcelcorso
Copy link
Contributor

Hey @andrewdbate . It looks good. All is fine.
I just don't like https://github.com/antihax/optional but it's not a direct dependency so nothing we can do about it.

Thank you

@marcelcorso marcelcorso merged commit c07809d into messagebird:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants