Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lint integration #112

Merged
merged 17 commits into from
Mar 18, 2022
Merged

golangci-lint integration #112

merged 17 commits into from
Mar 18, 2022

Conversation

dzyanis
Copy link
Contributor

@dzyanis dzyanis commented Mar 16, 2022

I'd recomend to use golangci-lint

@dzyanis dzyanis changed the title refactoring golangci-lint integration Mar 17, 2022
@marcelcorso
Copy link
Contributor

hey @dzyanis! Thank you for the PR. This looks good!
Wow! Tests!! ♥️

@marcelcorso
Copy link
Contributor

I have a question about golangci-lint. If we used a github action to run them(https://github.com/marketplace/actions/run-golangci-lint) ... Would it use the same conf file or we would have to move it to the action config?

@dzyanis
Copy link
Contributor Author

dzyanis commented Mar 17, 2022

Would it use the same conf file or we would have to move it to the action config?

Actially, I've never used GitHub Action. However, as I can see, they are different but have almost the same name.

  • .github/workflows/golangci-lint.yml is a config file for Action and it's about how to run the golangci-lint;
  • .golangci.yml is a config file for golangci-lint and it's about how to check the code.

And there is another approach: use git hooks instead. But it's up to you!

@marcelcorso marcelcorso merged commit c51ff90 into messagebird:master Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants