Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mail.ru Instant Messengers provider #94

Merged
merged 3 commits into from
May 22, 2021

Conversation

DrGonzo
Copy link

@DrGonzo DrGonzo commented May 18, 2021

No description provided.

@marcelcorso
Copy link
Contributor

hey @DrGonzo ! Wow ICQ! That's epic. Thank you.

Are you sure you want to use Mail.ru IM as a name for structs, configs and not ICQ?
Because mail.ru IM is also comprised of TamTam and Agent per their website. And you are using the icq api to send the messages...

Another question: it's hard for us to test every provider. Did you test this in production? To send a message?

thanks!

@DrGonzo
Copy link
Author

DrGonzo commented May 21, 2021

Mail.ru messengers ICQ(yep, icq over 10 year belongs to mail.ru), Agent and MyTeam now uses same protocol/api and i use official "mail-ru-im/bot-golang" lib (so i think "mail.ru im" less known but more fairly name) which says what override bot's API URL changes messenger. I adds "api.icq.net" as default in PR example config, but tested with internal "MyTeam" api url.

@marcelcorso
Copy link
Contributor

Oh I get it. It's a good idea to use the same protocol.
Ok! Let's merge this.
Thanks again for the PR.

@marcelcorso marcelcorso merged commit 7388129 into messagebird:master May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants