-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
-resolves google/filament#8296 Signed-off-by: Joel Winarske <[email protected]>
- Loading branch information
Showing
2 changed files
with
30 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
patches/filament/0001-descset-fix-lights-UBO-size-on-setBuffer.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
From cad3b12c5bee7e6962307510b59df37ed0fcf810 Mon Sep 17 00:00:00 2001 | ||
From: Joel Winarske <[email protected]> | ||
Date: Wed, 12 Feb 2025 08:29:16 -0800 | ||
Subject: [PATCH] descset: fix lights UBO size on setBuffer | ||
|
||
Fixes #8296 | ||
|
||
Signed-off-by: Joel Winarske <[email protected]> | ||
--- | ||
filament/src/ds/ColorPassDescriptorSet.cpp | 2 +- | ||
1 file changed, 1 insertion(+), 1 deletion(-) | ||
|
||
diff --git a/filament/src/ds/ColorPassDescriptorSet.cpp b/filament/src/ds/ColorPassDescriptorSet.cpp | ||
index e5234dd15..29bb4b6eb 100644 | ||
--- a/filament/src/ds/ColorPassDescriptorSet.cpp | ||
+++ b/filament/src/ds/ColorPassDescriptorSet.cpp | ||
@@ -131,7 +131,7 @@ void ColorPassDescriptorSet::init( | ||
BufferObjectHandle froxelBuffer) noexcept { | ||
for (auto&& descriptorSet: mDescriptorSet) { | ||
descriptorSet.setBuffer(+PerViewBindingPoints::LIGHTS, | ||
- lights, 0, sizeof(LightsUib)); | ||
+ lights, 0, CONFIG_MAX_LIGHT_COUNT * sizeof(LightsUib)); | ||
descriptorSet.setBuffer(+PerViewBindingPoints::RECORD_BUFFER, | ||
recordBuffer, 0, sizeof(FroxelRecordUib)); | ||
descriptorSet.setBuffer(+PerViewBindingPoints::FROXEL_BUFFER, | ||
-- | ||
2.48.1 | ||
|