Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xlink:role attribute to gmd:online tag. #219

Conversation

wangf1122
Copy link
Contributor

The validation was giving such error:
image

The issue is xlink:role attribute was missing from gmd:online tag. So after the fix. The xlink:role will be added if no $language parameter passed into the xsl, we use root/language to determine what that language is. Here is the result transformed XML:

image

@wangf1122 wangf1122 changed the title Add language attribute to gmd:online tag. Add xlink:role attribute to gmd:online tag. May 27, 2021
@akhamdo
Copy link

akhamdo commented May 28, 2021

@jodygarnett
Would it be possible to have a look as this is need for our next release?

@wangf1122
Copy link
Contributor Author

@jodygarnett

Also to mention, the language is unique language and no requirement for the language at all. Just curious if we can remove that schematron rule as alternative solution too? Thanks.

@josegar74
Copy link
Contributor

Some comments about this attribute:

  1. It was added to allow to select in the online resources dialog the resource language (this is a customisation done in the some versions of GeoNetwork), used to register the map services in RCS system, as when registering a map service required to be specified in both languages. This attribute was added as a convention, as there is no way to indicate a multilingual URL in gmd:onLine.

  2. With the current changes, it's added always with the metadata language, it's not a selection in the online resources dialog.

  3. Not sure if RCS is used yet? If not, I think the best would be to get rid of this attribute and update the validation rules.

@wangf1122
Copy link
Contributor Author

wangf1122 commented Jun 17, 2021

Will take 3) approach to remove the validation rule. I committed the code. The validation rule is removed and I revert xlink:role back to the old version. Please take a look. @josegar74

@ianwallen ianwallen requested a review from josegar74 June 29, 2021 11:03
@josegar74
Copy link
Contributor

Going to make a new PR, preserving the validation rules, but with this logic in the code to add online resources:

  • if the description ends with fra add in xlink:role="urn:xml:lang:fra-CAN"
  • If not (ie eng for fra-eng) add in xlink:role="urn:xml:lang:eng-CAN"

@wangf1122
Copy link
Contributor Author

This was replaced by #230.

@wangf1122 wangf1122 closed this Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants