Permissions for edit and maps. #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianwallen
reviewed
Nov 17, 2023
I think it would be difficult to do it by file extensions. I think the protocol should be added |
|
I created a separate issue to investigate adding the download protocol |
|
@ianwallen, updated the permissions for maps with the additional protocols. |
ianwallen
approved these changes
Dec 6, 2023
josegar74
added a commit
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #344
@ianwallen the configuration added in the pull request was missing.
The problem is that for download, we don't have a specific protocol in HNAP. Maybe we can check if the URL ends with some known formats. What do you think?