Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Safe reference implementation #103

Closed
thelastjosh opened this issue Aug 1, 2023 · 7 comments
Closed

Fix Safe reference implementation #103

thelastjosh opened this issue Aug 1, 2023 · 7 comments
Assignees
Labels
backend Related to reference implementations, indexing, behavior of explorer priority: high High priority

Comments

@thelastjosh
Copy link
Member

The proposalsURI for MetagovDAO, generated automatically through the Safe reference implementation, has no data: https://daostar.org/registration/mainnet:0x48d1981a86bf62f3f005b03dd106789fd2d28104

@thelastjosh thelastjosh added the priority: high High priority label Aug 1, 2023
@thelastjosh thelastjosh added the backend Related to reference implementations, indexing, behavior of explorer label Aug 3, 2023
@crazyyuan
Copy link
Collaborator

The Safe proposalsURI API provided by the backend adds the executed parameter to false, which means to get the currently unexecuted multisig-transactions, remove this parameter to get all the proposals.
Safe API: https://safe-transaction-mainnet.safe.global/
The fixed PR: #108

@thelastjosh
Copy link
Member Author

Obstacle discussed today was access permissions, I just added Kahn and Mike to the DAOstar team, which gives them access to the daostar-api repo, note that this code is deployed on the daostar-api Digital Ocean droplet (which I also gave them access to).

If you have any additional questions, ping @Rashmi-278 first because she went through some of hte same access control issues when fixing the frontend this week.

@Rashmi-278
Copy link
Member

@thelastjosh We are still facing access permissions issues unfortunately.

The backend has been deployed to AWS and we didn't have permissions to redeploy this.

Can we please get access to this?

@thelastjosh
Copy link
Member Author

thelastjosh commented Aug 15, 2023 via email

@thelastjosh
Copy link
Member Author

Emailed Kahn new credentials.

@Rashmi-278
Copy link
Member

We deployed the backend Rest API to metagov's AWS , the current deployment is in sync with main branch

@crazyyuan
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to reference implementations, indexing, behavior of explorer priority: high High priority
Projects
None yet
Development

No branches or pull requests

3 participants