Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach release manifests for clusterctl #30

Merged
merged 6 commits into from
Jan 21, 2025
Merged

Conversation

vknabel
Copy link
Contributor

@vknabel vknabel commented Jan 20, 2025

Description

For the previous release we hand-rolled this process
Closes #23
Closes #29

Here I attach all manifests at the release draft although there will be no tagged image yet. This way we can observe the behavior of the actual release process beforehand.

@vknabel vknabel force-pushed the attach-release-manifests branch from b752b2b to a5a2d21 Compare January 20, 2025 14:52
Copy link
Contributor

@robertvolkmann robertvolkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks that the other cluster API providers put their cluster-template.yaml into <rootDir>/templates/.

config/manager/manager.yaml Outdated Show resolved Hide resolved
config/manager/kustomization.yaml Outdated Show resolved Hide resolved
@robertvolkmann
Copy link
Contributor

cluster-template.yaml has only put to the release.

the no schedule taint will be removed once the machine is ready
@vknabel vknabel merged commit a4e6eca into main Jan 21, 2025
4 checks passed
@vknabel vknabel deleted the attach-release-manifests branch January 21, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing cluster-template.yaml Initial release and installation through clusterctl
2 participants