Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow override of reclaimPolicy #72

Merged
merged 6 commits into from
Dec 7, 2023
Merged

Allow override of reclaimPolicy #72

merged 6 commits into from
Dec 7, 2023

Conversation

P-n-I
Copy link
Contributor

@P-n-I P-n-I commented Nov 7, 2023

Retain the current default reclaimPolicy but, for each StorageClass provide Values to allow override.

@P-n-I P-n-I requested a review from a team as a code owner November 7, 2023 11:25
@P-n-I P-n-I marked this pull request as draft December 4, 2023 09:47
@P-n-I P-n-I marked this pull request as ready for review December 4, 2023 09:48
@P-n-I
Copy link
Contributor Author

P-n-I commented Dec 4, 2023

Hi @Gerrit91 I see you've approved another MR this morning, is there something I've got wrong or missed on this MR that's preventing it being looked at please?

@Gerrit91 Gerrit91 merged commit b533801 into metal-stack:master Dec 7, 2023
1 of 2 checks passed
@Gerrit91
Copy link
Contributor

Gerrit91 commented Dec 7, 2023

@P-n-I, sorry, I completely missed this PR. :(
Merged!

@P-n-I
Copy link
Contributor Author

P-n-I commented Dec 7, 2023

Many thanks! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gerrit91 Gerrit91 Gerrit91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@P-n-I @Gerrit91