Add rack completion for machine ls. (#246)

cmd/completion/machine.go

@@ -135,3 +135,24 @@ func (c *Completion) IssueSeverityCompletion(cmd *cobra.Command, args []string,
 
 	return names, cobra.ShellCompDirectiveNoFileComp
 }
+
+func (c *Completion) MachineRackListCompletion(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
+	mfr := &models.V1MachineFindRequest{}
+
+	if cmd.Flag("partition") != nil {
+		if partition := cmd.Flag("partition").Value.String(); partition != "" {
+			mfr.PartitionID = partition
+		}
+	}
+
+	resp, err := c.client.Machine().FindMachines(machine.NewFindMachinesParams().WithBody(mfr), nil)
+	if err != nil {
+		return nil, cobra.ShellCompDirectiveError
+	}
+	var names []string
+	for _, m := range resp.Payload {
+		names = append(names, m.Rackid)
+	}
+
+	return names, cobra.ShellCompDirectiveNoFileComp
+}

cmd/machine.go

@@ -45,6 +45,7 @@ func (c *machineCmd) listCmdFlags(cmd *cobra.Command, lastEventErrorThresholdDef
 		{flagName: "partition", f: c.comp.PartitionListCompletion},
 		{flagName: "size", f: c.comp.SizeListCompletion},
 		{flagName: "project", f: c.comp.ProjectListCompletion},
+		{flagName: "rack", f: c.comp.MachineRackListCompletion},
 		{flagName: "id", f: c.comp.MachineListCompletion},
 		{flagName: "image", f: c.comp.ImageListCompletion},
 		{flagName: "state", f: cobra.FixedCompletions([]string{

cmd/project.go

@@ -25,7 +25,7 @@ func newProjectCmd(c *config) *cobra.Command {
 
 	cmdsConfig := &genericcli.CmdsConfig[*models.V1ProjectCreateRequest, *models.V1ProjectUpdateRequest, *models.V1ProjectResponse]{
 		BinaryName:           binaryName,
-		GenericCLI:           genericcli.NewGenericCLI[*models.V1ProjectCreateRequest, *models.V1ProjectUpdateRequest, *models.V1ProjectResponse](w).WithFS(c.fs),
+		GenericCLI:           genericcli.NewGenericCLI(w).WithFS(c.fs),
 		Singular:             "project",
 		Plural:               "projects",
 		Description:          "a project belongs to a tenant and groups together entities in metal-stack.",

cmd/root_test.go

@@ -40,7 +40,9 @@ func Test_BasicRootCmdStuff(t *testing.T) {
 		_, err := w.Write(mustMarshal(t, &models.RestHealthResponse{
 			Status: pointer.Pointer(string(rest.HealthStatusHealthy)),
 		}))
-		require.NoError(t, err)
+		if err != nil {
+			t.Errorf("error writing response: %s", err)
+		}
 	}))
 	defer ts.Close()