publisher: attempt publishing both task, statusValue before returning an error #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an error - Ensure the task, status value updates are published regardless of a failure in either. - The Condition gets finalized in active-conditions as soon as status value includes a final state, this would prevent the Task from being updated since the condition is no longer active. Long term Status Value KV is to be replaced by the Task KV, until this this arrangement lets us work with both.
Instead of depending on it being passed through the NATS header from a message on the stream. Not all conditions are published through the stream and so the Condition payload now includes the trace, span IDs for linking work across controllers
splaspood
previously approved these changes
Sep 4, 2024
ofaurax
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long term Status Value KV is to be replaced by the Task KV, until this this arrangement lets us work with both.