Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ HostFirmwareComponents CRD and Controller & Tests #1559

Merged
merged 1 commit into from
Apr 5, 2024
Merged

✨ HostFirmwareComponents CRD and Controller & Tests #1559

merged 1 commit into from
Apr 5, 2024

Conversation

iurygregory
Copy link
Member

  • New Controller for HostFirmwareComponents
  • Updated the CRD based on kustomization
  • added GetFirmwareComponentsForNode to the Provisioner interface
  • implemented GetFirmwareComponentsForNode in ironic.go

What this PR does / why we need it:

metal3-io/metal3-docs#364

@metal3-io-bot metal3-io-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 15, 2024
@iurygregory iurygregory force-pushed the hfc-controller branch 2 times, most recently from 9fab17e to f862054 Compare February 16, 2024 03:02
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 16, 2024
@metal3-io-bot metal3-io-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 16, 2024
@iurygregory
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main

@iurygregory
Copy link
Member Author

cc @dtantsur @elfosardo @honza
If possible can you check if this is the right path ? =)
Going to work on unit tests for it

dtantsur
dtantsur reviewed Feb 20, 2024
View reviewed changes
dtantsur
dtantsur reviewed Feb 20, 2024
View reviewed changes
dtantsur
dtantsur reviewed Feb 20, 2024
View reviewed changes
@iurygregory iurygregory force-pushed the hfc-controller branch 2 times, most recently from 3392307 to dd3e962 Compare March 1, 2024 02:16
@iurygregory
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main

@iurygregory
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main

Didn't find any logs in the links .-. let's try again to see

@kashifest
Copy link
Member

/test metal3-bmo-e2e-test-pull

@iurygregory
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main

@iurygregory
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main

@iurygregory iurygregory requested review from dtantsur and zaneb April 1, 2024 13:34
@iurygregory
HostFirmwareComponents CRD and Controller
5473226 
- New Controller for HostFirmwareComponents
- Updated the CRD based on kustomization
- added GetFirmwareComponentsForNode to the Provisioner interface
- implemented GetFirmwareComponentsForNode in ironic.go
- Tests for HFC Controller

Signed-off-by: Iury Gregory Melo Ferreira <[email protected]>
@iurygregory
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main

@iurygregory iurygregory requested a review from dtantsur April 4, 2024 18:43
@honza
Copy link
Member

honza commented Apr 4, 2024

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2024
dtantsur
dtantsur reviewed Apr 5, 2024
View reviewed changes
pkg/provisioner/ironic/ironic.go
if componentListErr != nil {
bmcAccess, _ := p.bmcAccess()
if bmcAccess.FirmwareInterface() == "no-firmware" {
return nil, fmt.Errorf("node %s is using firmware interface %s: %w", ironicNode.UUID, bmcAccess.FirmwareInterface(), componentListErr)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a follow-up: we should not include node UUIDs or refer to nodes or interfaces in user-visible messages since users don't have access to Ironic. Here we should talk about the driver not supporting firmware updates.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1655 will take care of this and the other parts we discussed

@dtantsur
Copy link
Member

dtantsur commented Apr 5, 2024

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2024
@metal3-io-bot metal3-io-bot merged commit d8007f2 into metal3-io:main Apr 5, 2024
16 checks passed
@iurygregory iurygregory deleted the hfc-controller branch April 5, 2024 16:40
iurygregory added a commit to iurygregory/baremetal-operator that referenced this pull request Apr 8, 2024
@iurygregory
Improvements in HFC
39a8b07 
This commit is to address some feedback from metal3-io#1559.

- Automatically create the HFC for the BMH
- GetFirmwareComponents now takes into consideration that
  an empty list was returned and will only throw an error if
  the FirmwareInterface is different from `redfish`.
iurygregory added a commit to iurygregory/baremetal-operator that referenced this pull request Apr 8, 2024
@iurygregory
Fixes in HFC
819c22e 
This commit is to address some feedback from metal3-io#1559.

- Automatically create the HFC for the BMH
- GetFirmwareComponents now takes into consideration that
  an empty list was returned and will only throw an error if
  the FirmwareInterface is different from `redfish`.
@iurygregory iurygregory mentioned this pull request Apr 8, 2024
Merged
iurygregory added a commit to iurygregory/baremetal-operator that referenced this pull request Apr 8, 2024
@iurygregory
Fixes in HFC
0ca2876 
This commit is to address some feedback from metal3-io#1559.

- Automatically create the HFC for the BMH
- GetFirmwareComponents now takes into consideration that
  an empty list was returned and will only throw an error if
  the FirmwareInterface is different from `redfish`.

Signed-off-by: Iury Gregory Melo Ferreira <[email protected]>
@rabi rabi mentioned this pull request Apr 8, 2024
Merged
iurygregory added a commit to iurygregory/baremetal-operator that referenced this pull request Apr 9, 2024
@iurygregory
Fixes in HFC
94339e1 
This commit is to address some feedback from metal3-io#1559.

- Automatically create the HFC for the BMH
- GetFirmwareComponents now takes into consideration that
  an empty list was returned and will only throw an error if
  the FirmwareInterface is different from `redfish`.
- extended PrepareData to contain the TargetFirmwareComponents
- actionPreparing takes into account the HFC

Signed-off-by: Iury Gregory Melo Ferreira <[email protected]>
iurygregory added a commit to iurygregory/baremetal-operator that referenced this pull request Apr 10, 2024
@iurygregory
Fixes in HFC
ca6167f 
This commit is to address some feedback from metal3-io#1559.

- Automatically create the HFC for the BMH
- GetFirmwareComponents now takes into consideration that
  an empty list was returned and will only throw an error if
  the FirmwareInterface is different from `redfish`.
- extended PrepareData to contain the TargetFirmwareComponents
- actionPreparing takes into account the HFC

Signed-off-by: Iury Gregory Melo Ferreira <[email protected]>
iurygregory added a commit to iurygregory/baremetal-operator that referenced this pull request Apr 11, 2024
@iurygregory
Fixes in HFC
423a31e 
This commit is to address some feedback from metal3-io#1559.

- Automatically create the HFC for the BMH
- GetFirmwareComponents now takes into consideration that
  an empty list was returned and will only throw an error if
  the FirmwareInterface is different from `no-firmware`.
- extended PrepareData to contain the TargetFirmwareComponents
- actionPreparing takes into account the HFC

Signed-off-by: Iury Gregory Melo Ferreira <[email protected]>
iurygregory added a commit to iurygregory/baremetal-operator that referenced this pull request Apr 12, 2024
@iurygregory
Fixes in HFC
fafe7fa 
This commit is to address some feedback from metal3-io#1559.

- Automatically create the HFC for the BMH
- GetFirmwareComponents now takes into consideration that
  an empty list was returned and will only throw an error if
  the FirmwareInterface is different from `no-firmware`.
- extended PrepareData to contain the TargetFirmwareComponents
- actionPreparing takes into account the HFC

Signed-off-by: Iury Gregory Melo Ferreira <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtantsur dtantsur dtantsur left review comments

@zaneb zaneb Awaiting requested review from zaneb

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@iurygregory @kashifest @metal3-io-bot @honza @dtantsur @zaneb