-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider renaming clusterroles to deconflict with other workloads #322
Comments
makes sense to me. |
liornoy
added a commit
to liornoy/metallb-operator
that referenced
this issue
Mar 20, 2023
This commit renames the manager-role to metallb-manager-role to prevent collisions with other Cluster Roles resources. fixes metallb#322 Signed-off-by: liornoy <[email protected]>
liornoy
added a commit
to liornoy/metallb-operator
that referenced
this issue
Mar 20, 2023
This commit renames the manager-role to metallb-manager-role to prevent collisions with other Cluster Roles resources. fixes metallb#322 Signed-off-by: liornoy <[email protected]>
liornoy
added a commit
to liornoy/metallb-operator
that referenced
this issue
Mar 20, 2023
This commit renames the manager-role to metallb-manager-role to prevent collisions with other Cluster Roles resources. fixes metallb#322 Signed-off-by: liornoy <[email protected]>
liornoy
added a commit
to liornoy/metallb-operator
that referenced
this issue
Mar 20, 2023
This commit renames the manager-role to metallb-manager-role to prevent collisions with other Cluster Roles resources. fixes metallb#322 Signed-off-by: liornoy <[email protected]>
liornoy
added a commit
to liornoy/metallb-operator
that referenced
this issue
Mar 20, 2023
This commit renames the manager-role to metallb-manager-role to prevent collisions with other Cluster Roles resources. fixes metallb#322 Signed-off-by: liornoy <[email protected]>
liornoy
added a commit
to liornoy/metallb-operator
that referenced
this issue
Mar 21, 2023
This commit renames the manager-role to metallb-manager-role to prevent collisions with other Cluster Roles resources. Deleted unused YAMLs from bundle/manifests and config/rbac. fixes metallb#322 Signed-off-by: liornoy <[email protected]>
liornoy
added a commit
to liornoy/metallb-operator
that referenced
this issue
Mar 22, 2023
This commit renames the manager-role to metallb-manager-role to prevent collisions with other Cluster Roles resources. Deleted old and unused YAMLs from config/rbac. fixes metallb#322 Signed-off-by: liornoy <[email protected]>
liornoy
added a commit
to liornoy/metallb-operator
that referenced
this issue
Mar 22, 2023
* This commit renames the Role and ClusterRole "manager-role" to "metallb-manager-role" (plus the RoleBinding/ClusterRoleBinding resource) to prevent collisions with other resources in the cluster. * Deleted old and unused YAMLs from config/rbac. fixes metallb#322 Signed-off-by: liornoy <[email protected]>
fedepaol
pushed a commit
that referenced
this issue
Mar 23, 2023
* This commit renames the Role and ClusterRole "manager-role" to "metallb-manager-role" (plus the RoleBinding/ClusterRoleBinding resource) to prevent collisions with other resources in the cluster. * Deleted old and unused YAMLs from config/rbac. fixes #322 Signed-off-by: liornoy <[email protected]>
mlguerrero12
pushed a commit
to mlguerrero12/metallb-operator
that referenced
this issue
Mar 28, 2023
* This commit renames the Role and ClusterRole "manager-role" to "metallb-manager-role" (plus the RoleBinding/ClusterRoleBinding resource) to prevent collisions with other resources in the cluster. * Deleted old and unused YAMLs from config/rbac. fixes metallb#322 Signed-off-by: liornoy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi! Amazing software, y'all are awesome.
Would you consider renaming any non-namespaced (clusterwide) objects, to add the string 'metallb' somewhere in the name, in order to deconflict them from other workloads?
For example (in metallb-operator.yaml):
to this instead:
I recently discovered that we wiped out this clusterrole via kubectl apply of a templated helm chart for another service.
The text was updated successfully, but these errors were encountered: