Improvements to the E2E tests #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the way the MetalLBReconciler logs an error on the Reconcile function, added the error's content into the log. This change is required as we faced flakes hitting this line and not reporting the error, making it hard to debug. Signed-off-by: liornoy <[email protected]>
liornoy
changed the title
fedepaol
reviewed
Mar 31, 2023
| metallbutils.Delete(correct_metallb) | ||
| metallbutils.Delete(incorrect_metallb) |
There was a problem hiding this comment.
I think the right way to do is to revise Delete and have it "just" delete, and moving the check logic in another function, OR having a Delete and a DeleteAndCheck
liornoy
force-pushed
the
printerror
branch
2 times, most recently
from
c8a657f to
f66d59a
Compare
Split the Delete function to Delete and DeleteAndCheck so we'll be able to call only Delete on the incorrect_metallb resources and DeleteAndCheck on metallb resources where the additional check is required. Signed-off-by: liornoy <[email protected]>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes 2 small commits resulting from troubleshooting a bug:
an Incorrect_metallb resource where it shouldn't do the additional check whether the deployments and
daemonsets are deleted as well.