CI improvements #396
Merged
CI improvements #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimritproj
requested review from
fedepaol,
gclawes and
oribon
as code owners
shimritproj
force-pushed
the
Updated_ci.yaml_file
branch
2 times, most recently
from
8b32388 to
7471453
Compare
liornoy
reviewed
Oct 18, 2023
There was a problem hiding this comment.
Thank you for the PR! I added a couple of comments, some are just proposing renaming,
notice that some comments apply also to other places in the yaml that I didn't repeat.
Also, please add commit message that describes what and why we're doing in this change, you can take inspiration from the description in Jira.
shimritproj
force-pushed
the
Updated_ci.yaml_file
branch
from
503d8f5 to
5878e09
Compare
Thanks for the excellent review, I solved the comments. @liornoy |
shimritproj
force-pushed
the
Updated_ci.yaml_file
branch
3 times, most recently
from
3ed7b6d to
a7c21b6
Compare
liornoy
reviewed
Oct 22, 2023
liornoy
reviewed
Oct 22, 2023
shimritproj
force-pushed
the
Updated_ci.yaml_file
branch
3 times, most recently
from
9e9c108 to
c6bdfaa
Compare
shimritproj
force-pushed
the
Updated_ci.yaml_file
branch
12 times, most recently
from
710e65c to
722646b
Compare
shimritproj
force-pushed
the
Updated_ci.yaml_file
branch
6 times, most recently
from
9e59136 to
0a22ca9
Compare
|
@oribon I see we hit the known |
shimritproj
force-pushed
the
Updated_ci.yaml_file
branch
10 times, most recently
from
2453c2c to
73d71a4
Compare
shimritproj
force-pushed
the
Updated_ci.yaml_file
branch
2 times, most recently
from
aec8d1d to
8c0f285
Compare
oribon
reviewed
Dec 27, 2023
.github/workflows/ci.yaml
Outdated
Comment on lines
80
to
79
| - name: Verify manifests | ||
| run: | | ||
| make manifests | ||
| git diff --exit-code |
shimritproj
force-pushed
the
Updated_ci.yaml_file
branch
3 times, most recently
from
9912ada to
f691382
Compare
1. Combine workflows (general, go, metallb_e2e, olm, upgrade) under one workflow, leveraging the "needs" option for code reuse and requiring successful dependent jobs, thus improving readability. 2. Add merge_group. 3. Add composite. Signed-off-by: shimritproj <[email protected]>
shimritproj
force-pushed
the
Updated_ci.yaml_file
branch
from
eca587a to
9596904
Compare
Adding artifact names for each collected log will help us understand which logs are suitable for each job. In the end, we will be able to see links in the GitHub UI for all artifact names, and there, all the logs suitable for each job will be accessible. Signed-off-by: shimritproj <[email protected]>
shimritproj
force-pushed
the
Updated_ci.yaml_file
branch
from
7c23f7e to
affbc07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI runs different checks that validates stuff such as: commit message, unit-tests, images built, e2e tests, backward compatibility tests, and so on.
The checks are split into workflows.
For example, see workflows runs here: https://github.com/metallb/metallb/actions
The workflows running are defined under the /.github/workflows dir.
The goal of this story is to improve metallb-operator's CI by bringing few features we have in metallb's CI.
The features we want to bring are:
we have composite for setup and for collecting logs. we can benefit from it
also in the metallb-operator CI.