-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(URGENT) Bilingual collection not being generated for v2.01 and v3.01 #242
Comments
The resulting file listing is like this: I have attached the folder "brochure" as zipped below. Notice that under "brochure", these files are identical (i.e. contains nothing but just with a cover page:
The way to build this is to use the PR #256, i.e.:
|
Note that collection_en and collection_fr were being created all along, they are not new. |
I'm going to have to pass this on to @Intelligent2013 . The Presentation XML for the bilingual brochure is being generated as normal, and Alex is in a better position than me to assess what has gone wrong. I am passing the artefact on to him. |
The PDF error file notes a very large number of unresolved anchors, but I do not know if that is enough to explain it. |
This was a bug in the PDF stylesheet from the Presentation XML refactor, but @Intelligent2013 is still reviewing reported unresolved IDs, and I may follow them up myself. However he is getting the PDF now compiling correctly. |
BIPM XSLT updated. PDF generation issue fixed. Still there are 8 1st category
<xref target="cgpm9th1948r7r7_si-brochure-fr">Résolution 7</xref> 2nd category
In the table there are two <fn reference="b">
... Le radian est aussi l’unité cohérente d’angle<bookmark id="_da3c27e3-1a1d-4807-a3dd-1d610eb7bef0"/> de phase. Pour les phénomènes périodiques, l’angle<bookmark id="_fa209505-5cc5-4f9a-9ace-0062a888174e"/> de phase augmente de <stem block="false" type="MathML">
...
</fn> <fn reference="b">
... Le radian est aussi l’unité cohérente d’angle<bookmark id="_93cb06a5-66e8-4639-926f-cb193c5dbe62"/> de phase. Pour les phénomènes périodiques, l’angle<bookmark id="_13daa7c1-71a5-4e7e-8fb5-bc0481530dfa"/> de phase augmente de <stem block="false" type="MathML">
...
</fn> First
3rd category:
<bookmark to="regles_ecriture_si-brochure-fr" id="_cd3b0f9e-16a8-4548-90e5-dcb402ebdbc7"/>
...
<xref target="_cd3b0f9e-16a8-4548-90e5-dcb402ebdbc7" to="regles_ecriture_si-brochure-fr" pagenumber="true"> @opoudjis how should I process
|
No, it isn't working. I this case there are two elements with the same id <bookmark to="cdm_si-brochure-fr" id="_a8dfbb50-052f-49b4-8985-c64d668c57a1"/>
...
<clause id="cdm_si-brochure-fr" obligation="informative" displayorder="3"> Then, how to process |
cgpm9th1948r7r7_si-brochure-fr: sections-a1-en/05-9th-cgpm.adoc has
Its French counterpart is:
So the French crossreference needs to be to |
2nd category. Indeed, we have a repeated table footnote, and the footnote repetitions contain index references that are expanded:
This results in:
Now, as it turns out, the footnote is only rendered once, not twice. So the references to the two table footnote instances from the index need to be collapsed into one. But that I would argue is the responsibility of whoever is collapsing the two cross-references into one. If Presentation XML were collapsing the two footnotes into one, then it would be responsible for collapsing any crossreferences to them, removing cross-references to the content of the duplicate footnote. But we are leaving this as a format-specific collapse; it may not be observed by all downstream formats, because not all downstream formats may allow the one footnote to be shared among multiple cells. (I think we make it to anyway, but I'm arguing a principle here.) If HTML and PDF formatters are stripping footnote content as redundant, I think it is their responsibility to identify and remove anything cross-referencing that content. The clean option is that we should search for and remove any xref pointing to duplicate footnotes which we eliminate, in HTML and in PDF processing.... ... But first, that is going to be painful to do, without a lot of semantic annotation. Second, it is quite pedantic to insist on separate index entries for repeated footnotes, even if we do preserve the footnote. So I am going to go ahead, and detect and remove index entries from footnotes that I know to be duplicate of other footnotes. |
translates to:
which is pointed to by:
The intention is that the index entry "grandeurs,règles d’écriture" cover the span between where the index-range:[] macro is, and the anchor regles_ecriture. See https://www.metanorma.org/author/topics/inline_markup/index_terms/ , Entry ranges. That means that |
It is long overdue for me to collapse the ISO and BIPM indexing code, which are largely the same, and to move them to isodoc. BIPM differs from ISO in having subclauses, one per alphabetic letter; that will be treated as a BIPM specialisation. |
@Intelligent2013 Please confirm. Involves all of metanorma-standoc, isodoc, and metanorma-bipm |
Fixed.
@opoudjis there are 3 errors:
All these errors relate to the case when there is
I can't just ignore Here is example with working ...
doivent être précisés. <bookmark id="valeur_numerique_si-brochure-fr"/>
...
<xref target="_f15fba7b-f078-4462-9471-2e06b01dd464" to="valeur_numerique_si-brochure-fr" pagenumber="true"> As I remember this behavior added 4 years ago for metanorma/metanorma-bipm#67 (comment) How should I modify |
I get it. Clearly for And if there is no element with id = regles_ecriture, that is an editorial problem. They are here:
Note that other index-range macros work fine: index-range:prefixes_si-3[] works, because prefixes_si-3 is a bookmark given at the end of the subclause "Noms des unités". So there is nothing to fix in code: the error is in the text. So these three are bookmarks that have been left out in error on the French side. The English side is indexed quite differently, so I cannot extrapolate them from there. I am afraid therefore that I will need to refer you to the editors to fill these missing bookmarks in in the French document. |
Closing this ticket for the original issue. The remaining issue of indexes is moved to #273 . |
When I execute:
A
brochure/
folder is created where independent documents, English and French, generate properly. But the collection that contains both versions, not.The text was updated successfully, but these errors were encountered: