Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move "ReverseAdoc" functionality into the "Coradoc::Input::Html" class #100

Closed
ronaldtse opened this issue Jun 5, 2024 · 1 comment · Fixed by #118
Closed

Move "ReverseAdoc" functionality into the "Coradoc::Input::Html" class #100

ronaldtse opened this issue Jun 5, 2024 · 1 comment · Fixed by #118
Assignees
@webdev778 @hmdne
Labels
enhancement New feature or request
Milestone
1.0.0

Comments

@ronaldtse
Copy link
Contributor

Coradoc is basically a set of models that represent a document.

ReverseAdoc is basically an importer from HTML into the Coradoc models.

There are other importing formats that ReverseAdoc supports, including Word, and in the future, Markdown.

We should generalize ReverseAdoc which is HTML only into a “Coradoc::Importer” class to support additional formats and allow others to extend it as they require.
@ronaldtse ronaldtse mentioned this issue Jun 5, 2024
Closed
@ronaldtse ronaldtse added the enhancement New feature or request label Jun 6, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Metanorma Jul 11, 2024
@ronaldtse ronaldtse moved this from 🆕 New to 🌋 Urgent in Metanorma Jul 11, 2024
@ronaldtse ronaldtse changed the title Generalize “ReverseAdoc” into an “importer” pattern Move "ReverseAdoc" functionality into the "Coradoc::Input::Html" class Jul 11, 2024
@ronaldtse ronaldtse mentioned this issue Jul 11, 2024
Open
@ronaldtse ronaldtse added this to the 1.0.0 milestone Jul 11, 2024
@hmdne hmdne mentioned this issue Jul 11, 2024
Open
@github-project-automation github-project-automation bot moved this from 🌋 Urgent to ✅ Done in Metanorma Aug 23, 2024
@hmdne hmdne mentioned this issue Aug 23, 2024
Merged
4 tasks
@hmdne
Copy link
Contributor

hmdne commented Aug 24, 2024

We have mistakenly closed this issue. #118 needs to be merged first.

@hmdne hmdne reopened this Aug 24, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 🏗 In progress in Metanorma Aug 24, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Metanorma Aug 25, 2024
xyz65535 pushed a commit to xyz65535/coradoc that referenced this issue Aug 25, 2024
@hmdne @xyz65535
input/output/converter: input output pattern
2b4c74c 
This provides a backbone for implementing metanorma#72.

Convert reverse_adoc to Coradoc::Input::HTML (fixes metanorma#100)

This commit also implements Input::{Adoc,Docx} and Output::Adoc,
based on existing code.

Everything is handled by a new Converter class and our current
CLI tools are refactored to use the new Converter class. This gives
us a solid framework for implementing metanorma#64.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@webdev778 webdev778

@hmdne hmdne

Labels
enhancement New feature or request
Projects
Metanorma
Status: ✅ Done
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Converter pattern metanorma/coradoc
3 participants
@ronaldtse @webdev778 @hmdne