ISO-22726-1 compatibility fixes #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, caller is responsible for anchors
Rationale for that can be found in the comment: #133 (comment)
ronaldtse
approved these changes
Oct 4, 2024
ronaldtse
reviewed
Oct 4, 2024
| @@ -12,6 +12,16 @@ def initialize(*positional, **named) | |||
| @rejected_named = [] | |||
| end | |||
|
|
|||
| def inspect | |||
| "AttributeList: " + | |||
|
Not sure why not yet merged. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #133
In particular, it's concerned about extracting titles if they are nested in ordered lists.
Keep in mind, that this logic is done on coradoc tree, so it'll still be valid once we create a DOCX/ODT input.
Metanorma PR checklist