Coradoc::Input::HTML: Fix complex list items #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes handling of complex list items. Before Coradoc refactor, reverse_adoc used to treat all children of list elements as inline elements (if I recall correctly) After Coradoc refactor, we treat all children of list elements as non-online elements (necessitating line break). This broke certain assumptions we have while dealing with BIPM incoming documents. In particular, whenever there was a subscript involved, we get unexpected line breaks. This PR aims to correctly handle all inline and non-inline list children, according to AsciiDoc specification[1]. Since this is quite a large refactor of a crucial part of documents, this may break a couple of assumptions, so I would really appreciate some testing before merging that. [1] https://docs.asciidoctor.org/asciidoc/latest/lists/continuation/
|
I noted an error while converting expressions like |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| str.gsub(/\A[[:space:]]+|[[:space:]]+\z/, "") | ||
| def self.strip_unicode(str, only: nil) | ||
| str = str.gsub(/\A[[:space:]]+/, "") unless only == :end | ||
| str = str.gsub(/[[:space:]]+\z/, "") unless only == :begin |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
hmdne
added a commit
to metanorma/bipm-data-importer
that referenced
this pull request
Dec 13, 2024
- use additional urls for finding more content - use an experimental branch of Coradoc (metanorma/coradoc#143) - fix numbering for CGPM so that produced diff will be smaller - small fixes for parsing content This fixes #49 and this fixes #50
4 tasks
hmdne
added a commit
to metanorma/bipm-data-importer
that referenced
this pull request
Dec 13, 2024
- use additional urls for finding more content - use an experimental branch of Coradoc (metanorma/coradoc#143) - fix numbering for CGPM so that produced diff will be smaller - small fixes for parsing content This fixes #49 and this fixes #50
ronaldtse
approved these changes
Dec 14, 2024
ronaldtse
pushed a commit
to metanorma/bipm-data-importer
that referenced
this pull request
Dec 14, 2024
- use additional urls for finding more content - use an experimental branch of Coradoc (metanorma/coradoc#143) - fix numbering for CGPM so that produced diff will be smaller - small fixes for parsing content This fixes #49 and this fixes #50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes handling of complex list items.
Before Coradoc refactor, reverse_adoc used to treat all children of list elements as inline elements (if I recall correctly)
After Coradoc refactor, we treat all children of list elements as non-online elements (necessitating line break).
This broke certain assumptions we have while dealing with BIPM incoming documents. In particular, whenever there was a subscript involved, we get unexpected line breaks.
This PR aims to correctly handle all inline and non-inline list children, according to AsciiDoc specification[1].
Since this is quite a large refactor of a crucial part of documents, this may break a couple of assumptions, so I would really appreciate some testing before merging that.
[1] https://docs.asciidoctor.org/asciidoc/latest/lists/continuation/
@opoudjis @ronaldtse
Metanorma PR checklist