-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDF: New document type: Addendum (historic, 1997 and prior) #1219
Comments
@opoudjis the addendum cover page has the sentence: I can construct it by XSLT on-fly, but I need the additional data - formerly publication docidentifier. Could you add it? |
@opoudjis also, the 1st page contains the sentences: How to encode it? |
Ugh. The first will be easier than the second, and I think the second needs to be ad hoc text treated as metadata somehow. |
DAD, I have to assume, is a former notation for ADD; I am inferring that, because Russian uses Доп. for both DAD and ADD. Googling confirms that; for example, https://dl.acm.org/doi/pdf/10.1145/74674.74679 p. 101 uses DAD to reference ISO addenda, in 1988. So we have the adhoccery (which I'd rather we didn't support) of a current and a former equivalent notation of the same identifier: ISO 2533:1975/ADD 1:1985 is not an update of ISO 2533/DAD 1, they both are referring to the same thing. We do have
But that is not semantically the same thing. I will introduce (with no little disgust) I'm surprised to hear you can generate the associated text: you have everything you need in the i18n? |
I assume that DAD means 'Draft ADdendum'.
I mean just hard-coded the associated text into XSLT. Sure, it's does not follow the accepted practice. Initially this task was my, so I thought it was my problem. But if you include it into i18n, it will be more correctly. |
We have the unfortunate situation here that addenda are supposed to update original documents, and in fact the construction of addenda identifiers assumes that it does, with the document attribute --- so ISO 2533:1975/ADD 1:1985 updates ISO 2533:1975, and that is encoded expressly as --- but we can argue that ISO 2533:1975/ADD 1:1985 also updates its draft ISO 2533:1975/DAD 1. And we don't want to conflate the two relations. From https://www.relaton.org/model/relations/:
In these definitions, which I am not proposing to change, and which are taken from ISO 690,
"Updates" is valid, because both are published
We can't say they are updates, because updates are defined as being updates of published expressions. And intuitively that makes sense: drafts are realised in publications, they are not updated as publications ISO 123/ADD 1 updates ISO 123: yes, so long as we consider ISO 123:2000 and ISO 123:2010 editions of the same work, we must also consider ISO 123:2000/ADD 1:2001 and ISO 123:2000/AMD 1:2005 editions of the same work. The difference is that ISO 123:2000/ADD 1:2001 and ISO 123:2000/AMD 1:2005 amend ISO 123:2000, and ISO 123:2010 revises ISO 123:2000 So: ISO 123:2003 updates (=> revises) ISO 123:2001 And we can add hasDraft to updates as a relation between identifiers in bibdata, as we have comparable identifiers elsewhere (part-of, translated-from, adopted-from, annotation-of), in the relation_relations() method. So to capture the previous draft identifier, we need only add has-draft to relation_relations() for ISO. |
And, as a result of all this, I can provide you @Intelligent2013 with i18n text for how to describe the relation of a document to its has-draft predecessor if specified: ... but TBH, I'm challenged about how to fit all those bits together. I guess we can come up with the text of Technical Committee ISO/TC 20, Aircraft and space vehicles But we haven't hitherto internationalised it. But do you actually have access to a rendering of "Addendum 1 to Internatiational Standard ISO 2533-1975"? This sounds like a long format pubid-iso, and a horrible legacy format at that... |
The "this addendum is based on" is a piece of document history metadata, but expressed as a block, not just a document attribute line. We don't have document history in ISO, though we do in other flavours. I think we should treat this as a prefatory clause of type document-history, rather than as an attempt at machine readable data in a table --- that clause clearly is not machine readable. OK, this is messy, but I know how to do it now... |
I think the document author is responsible for the TC translation. For instance, in https://github.com/metanorma/mn-samples-iso/blob/main/sources/international-standard/rice-2023/document-en.adoc?plain=1: :technical-committee-number: 34
:secretariat: SAC
:technical-committee: Food products
:subcommittee-number: 4
:subcommittee: Cereals and pulses This document was prepared by Technical Committee ISO/TC
{technical-committee-number}, _{technical-committee}_, Subcommittee SC
{subcommittee-number}, _{subcommittee}_.
The original PDFs here: https://github.com/metanorma/iso-2533/tree/main/reference-docs. |
i18n of (formerly ID) is localization-string i18n of ... was developed by... is localization-string But given the instrumental case after было разработано, I think you're right, we should just insert both paragraphs as text... |
I would treat this as an initial admonition. It has already been encoded in the existing documents as a foreword. In my opinion not worth changing that encoding. |
I think now you are right that this should be supplied by the author, and I am putting it in a separate preface clause, of type "provenance". |
Over to you @Intelligent2013. I have added support for has-draft identifiers, but use the provenance preface clause instead. |
Hmm, the generated Presentation XML doesn't contain the element <metanorma-extension>
<presentation-metadata>
<name>document-scheme</name>
<value>1979</value>
</presentation-metadata>
</metanorma-extension> manually for testing purposes. |
And the |
XSLT updated for the provenance preface rendering.
Looks like I have to reinstall the Metanorma locally. |
Follow-on from #1150
New document type, Addendum, behaves similarly to Amendment in its bibdata, but unlike Amendment, is a complete document.
This actually already renders OK in PDF, except that I've placed the addendum title in
title[@type = 'title-add']
Dummy sample attached.
a1.presentation.xml.zip
The text was updated successfully, but these errors were encountered: