Features/private charset #825
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| end.join | ||
| end | ||
|
|
||
| def inline_anchor_bibref(node) |
There was a problem hiding this comment.
Assignment Branch Condition size for inline_anchor_bibref is too high. [<3, 15, 5> 16.09/15]
| end.map { |x| x.sub(/%+/, "%") }.join + (node.text || "") | ||
| end | ||
|
|
||
| def inline_anchor_xref_attrs1(match, target, text) |
There was a problem hiding this comment.
Cyclomatic complexity for inline_anchor_xref_attrs1 is too high. [8/6]
Perceived complexity for inline_anchor_xref_attrs1 is too high. [8/7]
|
|
||
| def concatenate_attributes_to_xref_text(node) | ||
| node.attributes.each_with_object([]) do |(k, v), m| | ||
| %w(path fragment refid).include?(k) and next |
There was a problem hiding this comment.
Avoid immutable Array literals in loops. It is better to extract it into a local variable or a constant.
| else | ||
| xml << node.text | ||
| end | ||
| end | ||
| end.join | ||
| end | ||
|
|
||
| def hash2styles(role) | ||
| CSV.parse_line(role, liberal_parsing: true). |
There was a problem hiding this comment.
Place the . on the next line, together with the method name.
| @@ -164,8 +54,8 @@ def latex_parse(text, xml, block) | |||
| latex = latex_parse1(text, block) or | |||
| return xml.stem type: "MathML", block: block | |||
| xml.stem type: "MathML", block: block do |s| | |||
| math = Nokogiri::XML.fragment(latex.sub(/<\?[^>]+>/, "")) | |||
| .elements[0] | |||
| math = Nokogiri::XML.fragment(latex.sub(/<\?[^>]+>/, "")). | |||
There was a problem hiding this comment.
Place the . on the next line, together with the method name.
| @@ -1005,8 +1007,8 @@ | |||
| </sections> | |||
| </standard-document> | |||
| OUTPUT | |||
| expect(xmlpp(strip_guid(Asciidoctor.convert(input, *OPTIONS)))) | |||
| .to be_equivalent_to xmlpp(output) | |||
| expect(xmlpp(strip_guid(Asciidoctor.convert(input, *OPTIONS)))). | |||
There was a problem hiding this comment.
Place the . on the next line, together with the method name.
| @@ -988,8 +990,8 @@ | |||
| </sections> | |||
| </standard-document> | |||
| OUTPUT | |||
| expect(xmlpp(strip_guid(Asciidoctor.convert(input, *OPTIONS)))) | |||
| .to be_equivalent_to xmlpp(output) | |||
| expect(xmlpp(strip_guid(Asciidoctor.convert(input, *OPTIONS)))). | |||
There was a problem hiding this comment.
Place the . on the next line, together with the method name.
| @@ -969,8 +971,8 @@ | |||
| </sections> | |||
| </standard-document> | |||
| OUTPUT | |||
| expect(xmlpp(strip_guid(Asciidoctor.convert(input, *OPTIONS)))) | |||
| .to be_equivalent_to xmlpp(output) | |||
| expect(xmlpp(strip_guid(Asciidoctor.convert(input, *OPTIONS)))). | |||
There was a problem hiding this comment.
Place the . on the next line, together with the method name.
| @@ -953,8 +955,8 @@ | |||
| </clause></sections> | |||
| </standard-document> | |||
| OUTPUT | |||
| expect(xmlpp(strip_guid(Asciidoctor.convert(input, *OPTIONS)))) | |||
| .to be_equivalent_to xmlpp(output) | |||
| expect(xmlpp(strip_guid(Asciidoctor.convert(input, *OPTIONS)))). | |||
There was a problem hiding this comment.
Place the . on the next line, together with the method name.
| @@ -911,8 +913,8 @@ | |||
| </references></bibliography> | |||
| </standard-document> | |||
| OUTPUT | |||
| expect(xmlpp(strip_guid(Asciidoctor.convert(input, *OPTIONS)))) | |||
| .to be_equivalent_to xmlpp(output) | |||
| expect(xmlpp(strip_guid(Asciidoctor.convert(input, *OPTIONS)))). | |||
There was a problem hiding this comment.
Place the . on the next line, together with the method name.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #825 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 62 63 +1
Lines 5233 5244 +11
=======================================
+ Hits 5130 5141 +11
Misses 103 103
☔ View full report in Codecov by Sentry. |
Metanorma PR checklist