Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-number for override of hierarchical section number: https://gi… #829

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

opoudjis
Copy link
Contributor

…thub.com/metanorma/metanorma-iso/issues/1044

Metanorma PR checklist

@opoudjis opoudjis self-assigned this Nov 13, 2023
OUTPUT
expect(xmlpp(strip_guid(Asciidoctor.convert(input, *OPTIONS))))
.to be_equivalent_to xmlpp(output)
end
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end at 506, 2 is not aligned with it "processes sections with number attributes" do at 367, 3.

@@ -364,6 +364,147 @@
.to be_equivalent_to xmlpp(output)
end

it "processes sections with number attributes" do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation detected.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6919479) 98.03% compared to head (d8db714) 98.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #829   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files          63       63           
  Lines        5244     5244           
=======================================
  Hits         5141     5141           
  Misses        103      103           
Files Coverage Δ
lib/metanorma/standoc/section.rb 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@opoudjis opoudjis merged commit f25f7d1 into main Nov 14, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant